4
16 Comments

As indie-hackers, do you use code reviews?

https://www.michaelagreiler.com/code-review-blog-post-series/

As indie-hackers, do you use code reviews?

I just started to release a code review blog post series I have been working on the last few weeks. There I share my lessons learned and experiences analyzing millions of code review comments (using machine learning and data mining techniques) and working with hundreds of engineers at one of the largest software companies.
https://www.michaelagreiler.com/code-review-blog-post-series/

As a solopreneur, I actually miss the input from my peers on my code. How about you?

Do you use code reviews as a part of your software engineering practice? If so, do you use tools or are you working more informal, like having over-the-shoulder reviews?

#tech-questions

submitted this linkon March 19, 2019
  1. 2

    No. I don't write any tests either. YOLO.

    1. 1

      Why are you not using code reviews? Do you work with a team?
      Why aren’t you testing? How elaborate and mature is your software system?

      1. 1

        I am solo. As a result, I don't have time to write tests nor do I think the investment will be worth it until I hit $2-3K MRR.

        I do have basic monitoring in place so I know when stuff goes wrong - Sentry, NewRelic, and basic analytics tracking. Since the stakes are low, I am content with fixing issues as they arise.

  2. 1

    I write no test. I have never used but the following link is code review as a service.
    http://pullrequest.com

    1. 1

      Thanks a lot. Looks awesome

  3. 1

    no code review. I test my code.

    1. 1

      Thanks for your input. Do you have a dev team or do you develop alone?

      1. 1

        my own. I document well though. Years of BIOS and kernel/device drivers experience...

  4. 1

    I've been a hard core indie developer for +10 years.

    Here's what I live by (mostly):

    • NEVER go without tests ... tests save you a MASSIVE amount of time. As soon as your code breaks you know where to fix it. Trying to track down a bug MONTHS after the regression is impossible. Just do test driven develop where you write tests as part of your development. Takes you ZERO minutes. The only downside is setting tests up to begin with. But the time saved will be worth it... trust me!

    • CI + CD ... constantly test and constantly release your code. 2x per week if you can and ideally 2x per day.

    • Create a feature branch, work in that branch, then merge to master but FIRST do a diff compare. ONLY merge if the diff looks sane.

    1. 1

      Hi Kevin,
      Thank you so much for your input.
      I second everything you say. Tests are so valuable and can save so much time.
      The diffing before merge is also an important step. If you use tools for doing Code Review and work in a team, this step is often the first while preparing a code review.

      Do you work as a single dev or do you have a team of developers?

      1. 1

        Both... team and individual.. the current startup is individual.

  5. 1

    Hello!

    That's a very good topic. I subscribed to your newsletter to know more, I'm curious about that.

    Otherwise: no, I don't do code review on my side projects. I do automated tests though. Having a service to have code review from random developers could be a good idea actually ...

    1. 1

      Hi Matthieu, thanks for your input. Thrilled you subscribed!
      I thought the same about getting input from other devs. Not sure how people that develop closed source feel about sharing their code with others.
      What do you think about that?

      1. 1

        I was wondering the same. Maybe a community around code review could help building trust between members. If I know (and maybe can select) the people who review my project, I would feel more confident.

        Still, if the product is a success, some reviewer could ask to have some kind of ROI... I don't know how it would work legally.

  6. 1

    Hi!

    You interested me with this topic. I always do core-review with my teammates and even more, i often do cr for myself or ask my friends to take a look when i am working alone.

    About tools... Code styling can be checked automatically but i prefer to do 'manual' code review by other developers who knows technology or system.

    Anyway, cool series, i will follow it!

    Have a nice day!

    1. 1

      Hi Michael, so glad you like the topic. I also show my code from time to time to dev friends to get input.
      Which tools do you use for automatic code styling? Do you also look for smells and anti-patterns such as cyclomatic complexity, fan-in and fan-out etc?