Public demo is live 🥳
by Daniel Veihelmann👉 https://demo.readyforreview.com
In the last couple of days, I (finally!) had some time to work on ReadyforReview again. The most notable outcome of this is the brand new public demo of the code review tool.
Go check it out if you are interested 😊
My main goal for the demo was to offer a hassle-free way to test the product, as screenshots can only tell you so much.
I intentionally made it so that you don't even have to sign up for the site, simply login and check it out.
Important: If you give it a try and have some thoughts (good or bad), let me know! 📩
-
2
Hi @danielv!
I really like the idea of your product, as I do a lot of code reviews as well. I just found a little bug in the demo: when you de-select all file filters, except for "deleted (1)", no file is showing up. When I select only "config (1)" the "gitlab-ci.yml" shows up. But I guess that shouldn't be hard for you to track down and fix.
After I opened the deleted file, I only got one file show in the preview pane, even when I select an edited file. Reloading the browser tab did solve the issue.
Currently I'm missing at least three features:
- make annotations/comments in the changed file
- directly jump to the next change in the file
- mark the file as reviewed
But I really like the idea and I'm eager to see any progress. This tool could be pretty helpful!
Best,
Sven-
1
Thanks a lot for writing down your feedback, Sven! @svzi It is very much appreciated!
Regarding your points:
-
You actually can comment right now 🙂 Simply select a code region (in the new file) and press 'c' on your keyboard. (There is actually a hint about this, it's just not shown due to some technical details in the demo. I'll fix this). Let me know if this works as expected and if you'd prefer this to work differently.
-
There is indeed a bug with the file contents for certain scenarios (= files that no longer exist on the target branch of the merge). I'll fix this.
-
"directly jump to the next change in the file" - Good point! I put it only my list.
-
"mark the file as reviewed" - yeah, this is also something I really miss. Probably the next thing I tackle, this ought to be quite useful.
Again, thanks for sharing your thoughts! It's very motivating to hear back from fellow indie hackers 🍻
Cheers,
Daniel-
1
I appreciate that you share your tool with us and that you're open for feedback, Daniel @danielv !
- Regarding "comments": Maybe you could improve the UI regarding the comment's a little bit. I'm used to the GitLab merge requests. I only need to hover the line number and a little chat bubble appears (suggesting that I can make a comment). That was something I did expect. From my point of view, it would be very helpful to re-use as much as possible from the UI the user is already used to. And for sure, extend it to the better. Also it's hard to guess that I need to click the line number and not the line itself. Because doing the latter, I only get a message saying "Cannot edit in read-only mode" (or something like that). Another thing I like more in the GitLab UI itself: the comment box is a text area and not just a text input. Your's is suggesting me to keep my comment short. But that's not what I always want to. Often times I review code from some junior devs and I like to explain what they should change and why they should. That's not something I would like to do in a single line text input...
- Regarding "directly jump to the next change in the file": That's something I like from my VS Code setup when comparing diffs.
- Regarding "mark the file as reviewed": Great!
Another thing I really like about what you build is the ability to host your own instance via Docker. Do you plan to keep that possibility? Any plans to open source your project? And idea how you will monetize it? Sorry for asking so much questions, but this is really something I start to care about.
Best,
Sven-
1
-
re. "comments": I agree, the current UI and workflow is a bit barebones and needs some love :)
-
re. shortcuts: Done ✅ I've just added the shortcuts for navigating the diff (right now works only when both files are open)
Feel free to give it a try with the public demo (Ctrl + ⬆ or Ctrl + ⬇ ). [A hard reload of the site may be required. ]
By the way: Alt + ⬆ or ⬇ navigates between the files .
I really like the docker setup, too, so I'll definitely keep it.
In terms of monetarization and/or open sourcing things: I honestly haven't thought too much about this (yet). Let's see where this is going 😉
Thanks again!
-
2
Thanks a lot for the very quick improvements. 👍
I will definitely keep an eye on this project and I look forward to the next versions!
-
-
-
2
Wow! This looks promising 😋